Skip to content

Commit

Permalink
feat: change enums of product targeting module to use union string
Browse files Browse the repository at this point in the history
  • Loading branch information
nguyentoanit committed Apr 20, 2020
1 parent f866520 commit 5f43bda
Show file tree
Hide file tree
Showing 6 changed files with 162 additions and 174 deletions.
7 changes: 5 additions & 2 deletions src/operations/bidding/types.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import * as t from 'io-ts'
import { KeywordId } from '../keywords/types'
import { AdGroupId } from '../ad-groups/types'
import { ProductPredicateType } from '../product-targeting/types'

export const KeywordBidRecommendationsMatchType = t.union([
t.literal('exact'),
Expand Down Expand Up @@ -159,7 +158,11 @@ export const BiddingTargetingExpression = t.strict({
*/
value: t.string,

type: t.union([BiddingKeywordPredicateType, ProductPredicateType, BiddingAutoPredicateType]),
type: t.union([
BiddingKeywordPredicateType,
BiddingProductPredicateType,
BiddingAutoPredicateType,
]),
})

export const BiddingTargetingExpressions = t.array(BiddingTargetingExpression)
Expand Down
Loading

0 comments on commit 5f43bda

Please sign in to comment.