style: fixes lint issues

ScaleLeap · Aug 9, 2021 · 0b2b7ab · 0b2b7ab
1 parent 7c74a36
commit 0b2b7ab
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 12 deletions.
diff --git a/src/jest-polly.test.ts b/src/jest-polly.test.ts
@@ -105,7 +105,7 @@ describe('jest-polly', () => {
  expect(message).toBe(RESPONSE)
  })
 
- // eslint-disable-next-line sonarjs/no-identical-functions
+ // eslint-disable-next-line radar/no-identical-functions
  it('does not expand previously stringified JSON response', async () => {
  expect.assertions(1)
 
@@ -141,7 +141,7 @@ describe('jest-polly', () => {
  expect(message).toStrictEqual({})
  })
 
- // eslint-disable-next-line sonarjs/no-identical-functions
+ // eslint-disable-next-line radar/no-identical-functions
  it('expands JSON request to JSON object', async () => {
  expect.assertions(1)
 

diff --git a/src/secrets-sanitizer.ts b/src/secrets-sanitizer.ts
@@ -21,18 +21,20 @@ export function normalizeSecrets(secrets: Secrets): NormalizedSecrets {
  return secrets
  }
 
- const accumulator: NormalizedSecrets = {}
+ const normalizedSecrets: NormalizedSecrets = {}
 
- secrets
- // eslint-disable-next-line unicorn/no-array-callback-reference
- .filter(isDefined) // removes undefines
- .filter((secret) => typeof secret === 'string' && !!secret) // non-empty string
- .forEach((secret) => Object.assign(accumulator, { [secret]: 'x' }))
+ const definedSecrets = secrets
+ .filter(isDefined)
+ .filter((secret) => typeof secret === 'string' && !!secret)
 
- return accumulator
+ for (const secret of definedSecrets) {
+ Object.assign(normalizedSecrets, { [secret]: 'x' })
+ }
+
+ return normalizedSecrets
 }
 
-// eslint-disable-next-line sonarjs/cognitive-complexity
+// eslint-disable-next-line radar/cognitive-complexity
 export function sanitize(recording: JsonObject, secrets: NormalizedSecrets): JsonObject {
  const accumulator: JsonObject = merge({}, recording)
 
@@ -48,15 +50,15 @@ export function sanitize(recording: JsonObject, secrets: NormalizedSecrets): Jso
  }
 
  if (Array.isArray(value)) {
- value.forEach((value_, index) => {
+ for (const [index, value_] of value.entries()) {
  if (typeof value_ === 'string') {
  value[index] = replaceAll(value_, secrets)
  }
 
  if (typeof value_ === 'object' && !Array.isArray(value_) && value_ !== null) {
  value[index] = sanitize(value_, secrets)
  }
- })
+ }
  }
  }