chore: terraform code refactoring #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iloveicedgreentea
requested review from
iloveicedgreentea,
aaronrea and
eric-gonzales
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Refactors terraform code making it easier to add more CIS Alerts as json files in AWS EventBridge format.
What image or gif best represents this PR?
https://tenor.com/view/1u-industrial-industrial-workers-of-the-world-injury-iww-gif-17596638
Why is this needed?
Less code is always good.
How does it work?
templatesdirectory prefixed withevent-, with a name of the event in the center (for example:console-login-without-mfa), and suffixed with.tmpl.json. Example file name:event-console-login-without-mfa.tmpl.jsonevent-, and creates corresponding EventBridge Rules and Targets for themThis way you can add/remove events dynamically to catch up with CIS requirements changes over time.
Please explain how this was tested
No unit tests were implemented, but I enjoy this solution on my client's environment, and want to say thank you very much for putting this together in the first place! This is amazing!!!
Screenshots (optional)
Documentation
Anything Else?