Skip to content

Commit

Permalink
Fix Windows-specific HandleSignal method signature
Browse files Browse the repository at this point in the history
  • Loading branch information
EtienneM committed Jul 1, 2019
1 parent b3f0c38 commit a49fd50
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 4 deletions.
2 changes: 1 addition & 1 deletion apps/run.go
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ func Run(opts RunOpts) error {

firstReadDone := make(chan struct{})
ctx := &runContext{
app: opts.App,
app: opts.App,
waitingTextOutputWriter: os.Stderr,
stdinCopyFunc: stdio.Copy,
stdoutCopyFunc: io.CopyWithFirstReadChan(firstReadDone),
Expand Down
10 changes: 7 additions & 3 deletions apps/run/run_windows.go
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
package run

import "net"
import "os"
import (
"net"
"os"

scalingo "github.com/Scalingo/go-scalingo"
)

func NotifiedSignals() chan os.Signal {
signals := make(chan os.Signal)
Expand All @@ -12,6 +16,6 @@ func NotifyTermSizeUpdate(signals chan os.Signal) {
return
}

func HandleSignal(s os.Signal, socket net.Conn, runUrl string) {
func HandleSignal(c *scalingo.Client, s os.Signal, socket net.Conn, runURL string) {
return
}

0 comments on commit a49fd50

Please sign in to comment.