Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add duration-before-trigger flag to alert creation and update #407

Merged
merged 6 commits into from
Apr 12, 2019
Merged

Add duration-before-trigger flag to alert creation and update #407

merged 6 commits into from
Apr 12, 2019

Conversation

EtienneM
Copy link
Member

@EtienneM EtienneM commented Apr 1, 2019

Related to Scalingo/scalingo-alerter-service#93

@EtienneM EtienneM marked this pull request as ready for review April 8, 2019 07:47
@EtienneM EtienneM requested a review from Soulou April 8, 2019 07:47
@Soulou
Copy link
Member

Soulou commented Apr 11, 2019

Example of output?

@EtienneM
Copy link
Member Author

EtienneM commented Apr 12, 2019 •
edited
Loading 

> ./cli -a gregfregegre alerts
+-----------------------------------------+--------+----------------+--------+----------------------+----------+
|                   ID                    | ACTIVE | CONTAINER TYPE | METRIC |        LIMIT         | DURATION |
+-----------------------------------------+--------+----------------+--------+----------------------+----------+
| al-dc6450de-7331-486d-89a2-409e17424c80 | true   | web            | rpm    | triggers above 15.00 | 3m0s     |
+-----------------------------------------+--------+----------------+--------+----------------------+----------+

@Soulou
Copy link
Member

Soulou commented Apr 12, 2019

Could we have this:

> ./cli -a gregfregegre alerts
+-----------------------------------------+--------+----------------+--------+----------------------+
|                   ID                    | ACTIVE | CONTAINER TYPE | METRIC |        TRIGGER       |
+-----------------------------------------+--------+----------------+--------+----------------------+
| al-dc6450de-7331-486d-89a2-409e17424c80 | true   | web            | rpm    | >= 15.00 (for 3m0s)  |
+-----------------------------------------+--------+----------------+--------+----------------------+

To me it's much clearer semantically, do you agree?

@EtienneM
Copy link
Member Author

EtienneM commented Apr 12, 2019 •
edited
Loading 

+-----------------------------------------+--------+----------------+--------+--------------------+
|                   ID                    | ACTIVE | CONTAINER TYPE | METRIC |       LIMIT        |
+-----------------------------------------+--------+----------------+--------+--------------------+
| al-dc6450de-7331-486d-89a2-409e17424c80 | true   | web            | rpm    | ≥ 15.00 (for 3m0s) |
+-----------------------------------------+--------+----------------+--------+--------------------+

@EtienneM EtienneM force-pushed the fix/alerter/93/alert_delay branch from a46ffb1 to 8467d4b Compare April 12, 2019 08:27
@Soulou Soulou merged commit 7372487 into master Apr 12, 2019
@EtienneM EtienneM deleted the fix/alerter/93/alert_delay branch May 17, 2021 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Soulou Soulou Awaiting requested review from Soulou

Assignees
No one assigned
Labels
reviewable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EtienneM @Soulou