Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multi-region #425

Merged
merged 8 commits into from
Jun 24, 2019
Merged

Support multi-region #425

merged 8 commits into from
Jun 24, 2019

Conversation

Soulou
Copy link
Member

@Soulou Soulou commented Jun 22, 2019

No description provided.

@Soulou Soulou requested a review from EtienneM June 22, 2019 19:50
Copy link
Member

@EtienneM EtienneM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we display somewhere the current region? I mean, if a user list his apps, how can he know on which zone he is? On the web dashboard, we have the zone selector for this. What about the CLI?

apps/run.go Outdated Show resolved Hide resolved
cmd/error.go Show resolved Hide resolved
cmd/regions.go Outdated Show resolved Hide resolved
config/config.go Show resolved Hide resolved
regions/regions.go Show resolved Hide resolved
@Soulou
Copy link
Member Author

Soulou commented Jun 24, 2019

Do we display somewhere the current region? I mean, if a user list his apps, how can he know on which zone he is? On the web dashboard, we have the zone selector for this. What about the CLI?

You're right, maybe scalingo config should display the current config of the CLI aka the region currently ?

Do you think we should display it when running a command also? Isn't that weird?

Soulou and others added 3 commits June 24, 2019 09:52
Co-Authored-By: Étienne M. <EtienneM@users.noreply.github.com>
Co-Authored-By: Étienne M. <EtienneM@users.noreply.github.com>
@Soulou Soulou requested a review from EtienneM June 24, 2019 08:29
@EtienneM
Copy link
Member

Do we display somewhere the current region? I mean, if a user list his apps, how can he know on which zone he is? On the web dashboard, we have the zone selector for this. What about the CLI?

You're right, maybe scalingo config should display the current config of the CLI aka the region currently ?

Do you think we should display it when running a command also? Isn't that weird?

scalingo config to return the current region might be enough in the first place. Let's see if we have some support about some lost customers later.

@Soulou
Copy link
Member Author

Soulou commented Jun 24, 2019

Adding a column region in the app list?

@EtienneM
Copy link
Member

Adding a column region in the app list?

When typing scalingo apps, we only display the apps in the current region, don't we? Adding a region column will just write N times the same information so I'm not really in favor of this. Does Heroku have multiple regions? Do they handle this use case?

@Soulou
Copy link
Member Author

Soulou commented Jun 24, 2019

@EtienneM Heroku output:

└> heroku apps
=== inscr@soulou.fr Apps
blooming-caverns-38122
radiant-sierra-63832

@Soulou
Copy link
Member Author

Soulou commented Jun 24, 2019

I'm going to implement config first and then we'll see

@Soulou
Copy link
Member Author

Soulou commented Jun 24, 2019

└> ./scalingo config
+-------------------+-----------+
| CONFIGURATION KEY |   VALUE   |
+-------------------+-----------+
| region            | agora-fr1 |
+-------------------+-----------+
└> ./scalingo regions      
+-----------+-------------+------------------------------------+
|   NAME    |   DISPLAY   |            API ENDPOINT            |
+-----------+-------------+------------------------------------+
| agora-fr1 | Paris (AC)  | https://api.agora-fr1.scalingo.com |
| osc-fr1   | Paris (OSC) | https://api.osc-fr1.scalingo.com   |
+-----------+-------------+------------------------------------+

@Soulou Soulou requested review from EtienneM and removed request for EtienneM June 24, 2019 09:31
@EtienneM EtienneM merged commit a2a2bfe into master Jun 24, 2019
@EtienneM EtienneM deleted the feature/regions branch June 24, 2019 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants