Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Git remote URL parsing to detect app name #443

Merged
merged 3 commits into from
Jul 15, 2019
Merged

Fix Git remote URL parsing to detect app name #443

merged 3 commits into from
Jul 15, 2019

Conversation

EtienneM
Copy link
Member

Fix #442

@EtienneM EtienneM marked this pull request as ready for review July 11, 2019 09:17
@EtienneM EtienneM requested a review from Soulou July 11, 2019 09:17
@Soulou
Copy link
Member

Soulou commented Jul 11, 2019

It seems quite easy to test, can you add one?

@EtienneM
Copy link
Member Author

Not that easy as it calls scalingoRemotes which uses the Git lib to extract the Git repo information and we have no interface to mock it..

@Soulou
Copy link
Member

Soulou commented Jul 11, 2019

You can separate in two functions, and one is taking the name of the remote where you do the test?

@EtienneM EtienneM force-pushed the fix/442/app_detection_git branch from 47f4e6e to 2986d7a Compare July 11, 2019 13:51
@EtienneM EtienneM requested review from Soulou and removed request for Soulou July 12, 2019 10:55
@Soulou Soulou merged commit 37bfe89 into master Jul 15, 2019
@EtienneM EtienneM deleted the fix/442/app_detection_git branch May 17, 2021 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Soulou Soulou Awaiting requested review from Soulou

Assignees
No one assigned
Labels
reviewable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

App detection based on Git config does not work anymore
2 participants
@EtienneM @Soulou