Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default destroy on stale is No #485

Merged
merged 1 commit into from
Sep 2, 2019
Merged

Default destroy on stale is No #485

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions cmd/integration_link.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,7 @@ func interactiveCreate() (scalingo.SCMRepoLinkParams, error) {
destroyOnClose := true
err = survey.AskOne(&survey.Confirm{
Message: "Automatically destroy review apps when the pull/merge request is closed:",
Default: true,
Default: destroyOnClose,
}, &destroyOnClose, nil)
if err != nil {
return params, err
Expand All @@ -364,10 +364,10 @@ func interactiveCreate() (scalingo.SCMRepoLinkParams, error) {
params.HoursBeforeDeleteOnClose = &hoursBeforeDestroyOnClose
}

destroyOnStale := true
destroyOnStale := false
err = survey.AskOne(&survey.Confirm{
Message: "Automatically destroy review apps after some time without deploy/commits:",
Default: true,
Default: destroyOnStale,
}, &destroyOnStale, nil)
if err != nil {
return params, err
Expand Down