Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not get the SCM integration when showing the integration link #492

Merged
merged 5 commits into from
Sep 24, 2019

Conversation

EtienneM
Copy link
Member

@EtienneM EtienneM commented Sep 24, 2019

╰─$ go build -o ./scalingo/scalingo ./scalingo && DEBUG=1 ./scalingo/scalingo --region osc-fr1 --app my-app integration-link
[DEBUG]2019/09/24 14:17:16 [Regions] Use the cache
[DEBUG]2019/09/24 14:17:16 [AppDetect] App name is my-app
[DEBUG]2019/09/24 14:17:16 [Regions] Use the cache
[DEBUG]2019/09/24 14:17:16 [API] POST https://auth.scalingo.com/v1/tokens/exchange
[DEBUG]2019/09/24 14:17:16       User Agent: 
[DEBUG]2019/09/24 14:17:16       Headers: map[User-Agent:[]]
[DEBUG]2019/09/24 14:17:16       Params: map[]
[DEBUG]2019/09/24 14:17:16       Request ID: 619d9539-f619-48a1-a668-b7da855f9b70
[DEBUG]2019/09/24 14:17:16       Duration: 243.335141ms
[DEBUG]2019/09/24 14:17:16 [API] GET https://api.osc-fr1.scalingo.com/v1/apps/my-app/scm_repo_link?
[DEBUG]2019/09/24 14:17:16       User Agent: Scalingo CLI v1.16.1
[DEBUG]2019/09/24 14:17:16       Headers: map[User-Agent:[Scalingo CLI v1.16.1]]
[DEBUG]2019/09/24 14:17:16       Params: map[]
[DEBUG]2019/09/24 14:17:16       Request ID: 51235409-d8cd-4c0b-80f4-d9a87a24496f
[DEBUG]2019/09/24 14:17:16       Duration: 93.161496ms
[DEBUG]2019/09/24 14:17:16 {"scm_repo_link":{"id":"","app_id":"","linker":{"username":"","email":"","id":"us-"},"owner":"Scalingo","repo":"myapp","branch":"develop","scm_type":"gitlab-self-hosted","created_at":"2019-09-23T10:11:03.360Z","updated_at":"2019-09-24T09:37:51.886Z","auto_deploy_enabled":true,"scm_integration_uuid":"","auth_integration_uuid":"","deploy_review_apps_enabled":true,"delete_on_close_enabled":true,"hours_before_delete_on_close":0,"delete_stale_enabled":false,"hours_before_delete_stale":0,"last_auto_deploy_at":null}}
Application: my-app (5d889a20fb0de6000ef4cc6f)
Integration: GitLab self-hosted (932ed9f8-2eb4-4dfc-b4a9-5060593d0b46)
Linker: Oim

Repository: Scalingo/myapp
Auto Deploy: ✔ develop
Review Apps Deploy: ✔
        Destroy on Close: instantly
        Destroy on Stale: ✘

Fix #491

Waiting for Scalingo/go-scalingo#139 to be merged

@EtienneM EtienneM marked this pull request as ready for review September 24, 2019 13:15
@EtienneM EtienneM requested a review from johnsudaar September 24, 2019 13:15
Copy link
Contributor

@johnsudaar johnsudaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EtienneM EtienneM merged commit ecfd2ae into master Sep 24, 2019
@EtienneM EtienneM deleted the fix/491/integration_link_no_integration_link branch September 24, 2019 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Integration Link] Displaying integration link information should not query the integration information
2 participants