Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(scale): rename command ps to scale without arg #631

Merged
merged 2 commits into from
Mar 25, 2021
Merged

feat(scale): rename command ps to scale without arg #631

merged 2 commits into from
Mar 25, 2021

Conversation

EtienneM
Copy link
Member

@EtienneM EtienneM commented Mar 23, 2021 •
edited by jira bot
Loading 

╰─$ go build -o scalingo-cli ./scalingo && ./scalingo-cli -a biniou scale
+------+--------+------+---------+
| NAME | AMOUNT | SIZE | COMMAND |
+------+--------+------+---------+
| web  |      1 | M    | -       |
+------+--------+------+---------+

Related to OPSB-252

  • Add a changelog entry in the section "To Be Released" of CHANGELOG.md

@EtienneM EtienneM force-pushed the fix/OPSB-252/rename_ps_scale branch from 5dad299 to 9e89379 Compare March 23, 2021 14:07
Soulou
Soulou reviewed Mar 23, 2021
View reviewed changes
cmd/scale.go Outdated
if len(c.Args()) == 0 {
err := cli.ShowCommandHelp(c, "scale")
err := apps.Containers(currentApp)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rename apps.ContainerTypes() and match this nomenclature which is more accurate about the name of our resources?

@EtienneM EtienneM requested a review from Soulou March 23, 2021 14:14
@EtienneM EtienneM marked this pull request as ready for review March 23, 2021 14:54
@EtienneM EtienneM mentioned this pull request Mar 24, 2021
Merged
1 task
Soulou
Soulou approved these changes Mar 25, 2021
View reviewed changes
Copy link
Member

@Soulou Soulou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Soulou Soulou merged commit 71ef5da into master Mar 25, 2021
@Soulou Soulou deleted the fix/OPSB-252/rename_ps_scale branch March 25, 2021 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Soulou Soulou Soulou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EtienneM @Soulou