Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(env-get): add command #643

Merged
merged 1 commit into from
Mar 31, 2021
Merged

feat(env-get): add command #643

merged 1 commit into from
Mar 31, 2021

Conversation

EtienneM
Copy link
Member 

╰─$ go build -o scalingo-cli ./scalingo && ./scalingo-cli -a biniou env-get DATABASE_URL
postgres://biniou_123:ZkH-Ri123WIs123haBQ3@biniou-123.postgresql.dbs.scalingo.com:35123/biniou_123?sslmode=prefer

Fix #439

  • Add a changelog entry in the section "To Be Released" of CHANGELOG.md

@EtienneM EtienneM marked this pull request as ready for review March 31, 2021 15:57
EtienneM
EtienneM commented Mar 31, 2021
View reviewed changes
env/display.go
if err != nil {
return "", errgo.Notef(err, "fail to get Scalingo client to get an environment variable")
}
vars, err := c.VariablesListWithoutAlias(appName)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used VariablesListWithoutAlias rather than VariablesList. For instance, if a customer execute env-get DATABASE_URL, I want to display the actual value rather than $SCALINGO_POSTGRESQL_VALUE.

@EtienneM EtienneM requested a review from johnsudaar March 31, 2021 15:59
@EtienneM EtienneM merged commit a5e4a3c into master Mar 31, 2021
@EtienneM EtienneM deleted the fix/439/env_get branch March 31, 2021 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnsudaar johnsudaar johnsudaar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an env-get command
2 participants
@EtienneM @johnsudaar