Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(logs) Buffer logs to prevent requests from timing out #659

Merged
merged 3 commits into from
May 27, 2021
Merged

fix(logs) Buffer logs to prevent requests from timing out #659

merged 3 commits into from
May 27, 2021

Conversation

johnsudaar
Copy link
Contributor

@johnsudaar johnsudaar commented May 27, 2021 •
edited by jira bot
Loading

Fix #658

  • Add a changelog entry in the section "To Be Released" of CHANGELOG.md

SRE-68

@johnsudaar johnsudaar requested a review from EtienneM May 27, 2021 12:20
@johnsudaar johnsudaar marked this pull request as ready for review May 27, 2021 12:26
@johnsudaar
Copy link
Contributor Author

johnsudaar commented May 27, 2021 •
edited
Loading

Small before and after
2021-05-27_14-27

EtienneM
EtienneM approved these changes May 27, 2021
View reviewed changes
Copy link
Member

@EtienneM EtienneM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, nicely caught!!! I assume this is related to the customer report from yesterday?

Thanks a lot for the comprehensive comments, this is really nice to read 🙂

I think we should do a release of the CLI so that this fix is out as soon as possible. Do you handle it or should I?

@johnsudaar
Copy link
Contributor Author

johnsudaar commented May 27, 2021 •
edited
Loading

Wow, nicely caught!!! I assume this is related to the customer report from yesterday?

Thanks :) It took us some time to undestand what happened with @Soulou but we finally got it !

I think we should do a release of the CLI so that this fix is out as soon as possible. Do you handle it or should I?

Yes if we could release a new version of the CLI soon it would much appreciated. If you have time i would love if you could do it.

@johnsudaar johnsudaar merged commit d4b6413 into master May 27, 2021
@johnsudaar johnsudaar deleted the fix/658/buffered_logs branch May 27, 2021 13:14
@EtienneM
Copy link
Member

OK I'll do it asap, tomorrow max

@johnsudaar
Copy link
Contributor Author

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EtienneM EtienneM EtienneM approved these changes

Assignees
No one assigned
Labels
reviewable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Logs] Missing logs
3 participants
@johnsudaar @EtienneM @john-scalingo