Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add command to list an App Cron Jobs #670

Merged
merged 2 commits into from
Aug 20, 2021
Merged

Add command to list an App Cron Jobs #670

merged 2 commits into from
Aug 20, 2021

Conversation

TheoEb
Copy link
Contributor

@TheoEb TheoEb commented Jul 20, 2021 •
edited
Loading

Related to CRON-50

scalingo -a [app_name] cron-jobs
image

Need go-scalingo to be released

  • Add a changelog entry in the section "To Be Released" of CHANGELOG.md

@TheoEb TheoEb requested a review from EtienneM July 20, 2021 13:14
@TheoEb TheoEb force-pushed the feat/list-cron-jobs branch from f2adcfb to 2f9befc Compare July 20, 2021 13:16
EtienneM
EtienneM requested changes Jul 20, 2021
View reviewed changes
Copy link
Member

@EtienneM EtienneM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add an example of how it looks in the first message of the PR?

CHANGELOG.md Outdated Show resolved Hide resolved
cmd/cron_tasks.go Outdated Show resolved Hide resolved
cmd/cron_tasks.go Outdated Show resolved Hide resolved
crontasks/list.go Outdated Show resolved Hide resolved
@TheoEb TheoEb force-pushed the feat/list-cron-jobs branch from 2f9befc to 6410eb0 Compare July 20, 2021 15:59
@TheoEb TheoEb requested a review from EtienneM July 20, 2021 15:59
@TheoEb TheoEb force-pushed the feat/list-cron-jobs branch from 6410eb0 to cdc7bfa Compare August 19, 2021 14:32
@TheoEb TheoEb marked this pull request as ready for review August 19, 2021 14:33
@EtienneM EtienneM force-pushed the feat/list-cron-jobs branch from cdc7bfa to 690ae92 Compare August 20, 2021 06:39
@EtienneM EtienneM force-pushed the feat/list-cron-jobs branch from 690ae92 to c29097d Compare August 20, 2021 06:44
@EtienneM EtienneM merged commit c3b783d into master Aug 20, 2021
@EtienneM EtienneM deleted the feat/list-cron-jobs branch August 20, 2021 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EtienneM EtienneM EtienneM approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheoEb @EtienneM