Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented deploy --no-follow flag #679

Merged
merged 1 commit into from
Sep 24, 2021
Merged

Implemented deploy --no-follow flag #679

merged 1 commit into from
Sep 24, 2021

Conversation

stopostit
Copy link
Contributor

@stopostit stopostit commented Sep 23, 2021 •
edited
Loading

Fix #650

  • Add a changelog entry in the section "To Be Released" of CHANGELOG.md

@stopostit stopostit requested a review from EtienneM September 23, 2021 15:46
@stopostit stopostit force-pushed the feat/650/no-follow_flag branch from 03b4db5 to 16fb45c Compare September 23, 2021 15:58
EtienneM
EtienneM reviewed Sep 23, 2021
View reviewed changes
Copy link
Member

@EtienneM EtienneM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just adding some comments about the content of the documentation. Otherwise it looks overall good to me

cmd/deployments.go Outdated Show resolved Hide resolved
deployments/deploy.go Outdated Show resolved Hide resolved
@stopostit stopostit force-pushed the feat/650/no-follow_flag branch from 16fb45c to 34e7c3c Compare September 23, 2021 16:42
@stopostit stopostit force-pushed the feat/650/no-follow_flag branch from 34e7c3c to e815aaf Compare September 23, 2021 16:47
@EtienneM EtienneM self-requested a review September 23, 2021 16:58
EtienneM
EtienneM requested changes Sep 23, 2021
View reviewed changes
Copy link
Member

@EtienneM EtienneM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test

@EtienneM EtienneM self-requested a review September 23, 2021 16:59
EtienneM
EtienneM reviewed Sep 23, 2021
View reviewed changes
Copy link
Member

@EtienneM EtienneM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gregregre

EtienneM
EtienneM requested changes Sep 23, 2021
View reviewed changes
Copy link
Member

@EtienneM EtienneM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test

EtienneM
EtienneM approved these changes Sep 24, 2021
View reviewed changes
Copy link
Member

@EtienneM EtienneM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍🏾

@EtienneM EtienneM merged commit 60af36b into master Sep 24, 2021
@EtienneM EtienneM deleted the feat/650/no-follow_flag branch September 24, 2021 07:01
@Intrepidd
Copy link

Thank you so much for implementing this ! I'd love to use it ASAP, would it be possible to release it ? Thanks !

@Soulou
Copy link
Member

Soulou commented Oct 5, 2021

Ping @EtienneM

@EtienneM
Copy link
Member

EtienneM commented Oct 7, 2021

Thank you so much for implementing this ! I'd love to use it ASAP, would it be possible to release it ? Thanks !

Hi @Intrepidd! We plan to release a new version by the end of next week :)

@EtienneM
Copy link
Member

@Intrepidd We just released the CLI v1.21.1 which implements this feature. You can follow the instructions on this page to upgrade: https://doc.scalingo.com/cli

@Intrepidd
Copy link

Thanks so much ! On my way to reduce my deploy scripts by 90% 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EtienneM EtienneM EtienneM approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[deploy] an option should allow a user not to wait for the end of the deployment (just triggering it)
4 participants
@stopostit @Intrepidd @Soulou @EtienneM