Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fields to cron tasks list #685

Merged
merged 4 commits into from
Oct 20, 2021
Merged

Add fields to cron tasks list #685

merged 4 commits into from
Oct 20, 2021

Conversation

TheoEb
Copy link
Contributor

@TheoEb TheoEb commented Oct 13, 2021 •
edited
Loading

  • Add a changelog entry in the section "To Be Released" of CHANGELOG.md

Related to CRON-89

Need go-scalingo release : Scalingo/go-scalingo#231

image
image

@TheoEb TheoEb requested a review from EtienneM October 13, 2021 12:32
@TheoEb TheoEb force-pushed the feat/CRON-89/add-fields-cron branch from bac4831 to f96678e Compare October 13, 2021 12:33
EtienneM
EtienneM requested changes Oct 18, 2021
View reviewed changes
Copy link
Member

@EtienneM EtienneM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase with master and fix the specs?

crontasks/list.go Outdated Show resolved Hide resolved
@TheoEb TheoEb force-pushed the feat/CRON-89/add-fields-cron branch 2 times, most recently from dd91a05 to 0b3032b Compare October 18, 2021 15:18
@TheoEb
Copy link
Contributor Author

TheoEb commented Oct 18, 2021

Can you rebase with master and fix the specs?

No specs to fix, we just need a release of go-scalingo

@TheoEb TheoEb requested a review from EtienneM October 18, 2021 15:18
@TheoEb TheoEb force-pushed the feat/CRON-89/add-fields-cron branch from 0b3032b to d648ef0 Compare October 20, 2021 10:05
@TheoEb TheoEb marked this pull request as ready for review October 20, 2021 10:15
@TheoEb TheoEb merged commit 874f4fc into master Oct 20, 2021
@TheoEb TheoEb deleted the feat/CRON-89/add-fields-cron branch October 20, 2021 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EtienneM EtienneM EtienneM approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheoEb @EtienneM