Feat(addons-info): Add addons-info command and documentation #689
Conversation
addons/info.go
Outdated
|
|
||
| forceSsl, internetAccess := "disabled", "disabled" | ||
| if featuresLen := len(dbInfo.Features); featuresLen > 0 { | ||
| if featuresLen == 2 { |
There was a problem hiding this comment.
This is not really true. There is a possibility that length is greater than 2 and that internet access is enabled.
There was a problem hiding this comment.
Do you know where I can find the list of possible features for a db ? Thought they were only two.
There was a problem hiding this comment.
We don't maintain a comprehensive list of features. Do you have access to appsdeck-database code?
There was a problem hiding this comment.
OK so you don't have access to the full list of features.. 😓
CHANGELOG.md
Outdated
| @@ -2,6 +2,8 @@ | |||
|
|
|||
| ### To be Released | |||
|
|
|||
| * feat(addons-info): add command `addons-info` to display information of an add-on [#578](https://github.com/Scalingo/cli/pull/689) | |||
There was a problem hiding this comment.
| * feat(addons-info): add command `addons-info` to display information of an add-on [#578](https://github.com/Scalingo/cli/pull/689) | |
| * feat(addons-info): add command `addons-info` to display information of an add-on [#689](https://github.com/Scalingo/cli/pull/689) |
addons/info.go
Outdated
| forceSsl = strings.ToLower(dbInfo.Features[i]["status"]) | ||
| } else if dbInfo.Features[i]["name"] == "publicly-available" { | ||
| internetAccess = strings.ToLower(dbInfo.Features[i]["status"]) | ||
| break |
There was a problem hiding this comment.
You shouldn't break in this condition, there is no guarantee of the features order
| break |
There was a problem hiding this comment.
Actually there is, since you cannot make your addon publicly available if SSL isn't enforced, so it has to be after the SSL entry. I've checked. What do you think ?
There was a problem hiding this comment.
Even though you supposedly can't enforce Public availability without Force TLS, the order of the features in the array is not guaranteed at all in the code. I can imagine a scenario where this is not the case. For instance, in case of issue with these features, an operator can manually work on the database and the order of features on the database is not guaranteed
There was a problem hiding this comment.
I see, I'll remove it then. Thanks for the explanation.
Add
addons-infocommand to display addon information :Fix #578