feat(router-logs): add command to enable/disable router-logs #692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why there isn't a description of |
I'm not sure I understand what you mean here. Can you elaborate a bit? |
EtienneM
approved these changes
Nov 3, 2021
sihamais
commented
Nov 3, 2021
README.md
Outdated
Comment on lines
102
to
103
| force-https | ||
| sticky-session |
There was a problem hiding this comment.
Here, these commands do not have a description on the README, I was wondering why ? @EtienneM
There was a problem hiding this comment.
Oh I didn't noticed 😅
I think it's missing. If you can add a description on these commands to that would be nice
EtienneM
requested changes
Nov 3, 2021
Co-authored-by: Étienne M. <EtienneM@users.noreply.github.com>
Co-authored-by: Étienne M. <EtienneM@users.noreply.github.com>
EtienneM
reviewed
Nov 3, 2021
…eat/605/router-logs
Co-authored-by: Étienne M. <EtienneM@users.noreply.github.com>
EtienneM
approved these changes
Nov 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #605