Fix/537/detect region from git remote #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnsudaar
reviewed
May 16, 2022
EtienneM
requested changes
May 17, 2022
mrunichs
force-pushed
the
fix/537/detect_region_from_git_remote
branch
from
0b85353 to
2f23272
Compare
EtienneM
reviewed
May 27, 2022
|
|
||
| "github.com/Scalingo/cli/config" | ||
| "github.com/Scalingo/cli/utils" | ||
|
|
There was a problem hiding this comment.
Are you sure your IDE is correctly configured?
Suggested change
There was a problem hiding this comment.
I will fix that and have a look at my linter configuration.
| "gopkg.in/errgo.v1" | ||
|
|
||
| "github.com/Scalingo/cli/utils" | ||
|
|
| if dir, ok := utils.DetectGit(); ok { | ||
| remotes, err := utils.ScalingoGitRemotes(dir) | ||
| if err != nil { | ||
| debug.Println(err) |
There was a problem hiding this comment.
Why are the errors not returned and directly printed in a debug log? This is not the choice made for apps (cf. GetAppNameFromGitRemote).
There was a problem hiding this comment.
It's the same for the app part (CurrentApp), at first, this error was simply ignored, @johnsudaar thought it could be convenient to print it in a debug log. It's not a blocking error, we do not want to make anything out of it. We simply return an empty string and the --region flag is use instead.
EtienneM
approved these changes
May 27, 2022
johnsudaar
approved these changes
May 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #537
Detect region from current git remote
appdetectpackage has been replaced bydetectwhich handles app and region detectionGit related methods have been moved in the
utilspackageAdd a changelog entry in the section "To Be Released" of CHANGELOG.md