Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(run_unix): replace github.com/heroku/hk/term with golang.org/x/term #740

Merged
merged 6 commits into from
Jul 22, 2022
Merged

refactor(run_unix): replace github.com/heroku/hk/term with golang.org/x/term #740

merged 6 commits into from
Jul 22, 2022

Conversation

EtienneM
Copy link
Member

@EtienneM EtienneM commented Jul 21, 2022 •
edited
Loading

Fix #465

  • Add a changelog entry in the section "To Be Released" of CHANGELOG.md

@EtienneM EtienneM changed the title refactor(run_unix): replace github.com/heroku/hk/term with x/crypto/ssh/terminal refactor(run_unix): replace github.com/heroku/hk/term with golang.org/x/term Jul 21, 2022
@EtienneM EtienneM marked this pull request as ready for review July 21, 2022 20:15
@EtienneM EtienneM requested a review from curzolapierre July 21, 2022 20:15
@EtienneM EtienneM enabled auto-merge July 22, 2022 07:09
@EtienneM EtienneM requested a review from brandon-welsch July 22, 2022 08:51
brandon-welsch
brandon-welsch approved these changes Jul 22, 2022
View reviewed changes
Copy link
Member

@brandon-welsch brandon-welsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bye bye old dependency. LGTM

@EtienneM EtienneM merged commit d0c9d92 into master Jul 22, 2022
@EtienneM EtienneM deleted the fix/465/hk_deprecated branch July 22, 2022 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandon-welsch brandon-welsch brandon-welsch approved these changes

@curzolapierre curzolapierre Awaiting requested review from curzolapierre

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should not use github.com/heroku/hk/term which is deprecated for 5 years
2 participants
@EtienneM @brandon-welsch