Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(make-release): use gox #747

Merged
merged 1 commit into from
Jul 25, 2022
Merged

feat(make-release): use gox #747

merged 1 commit into from
Jul 25, 2022

Conversation

EtienneM
Copy link
Member

@EtienneM EtienneM commented Jul 22, 2022

Execution example:

 emichon@biniou  ~/Documents/Scalingo/golang/src/github.com/Scalingo/cli   fix/739/gox ✚  ./dists/make-release.sh -j 3 -v $VERSION
Remove previously compiled binaries
Compiling the binaries for all architectures
Number of parallel builds: 3

-->     linux/amd64: github.com/Scalingo/cli/scalingo
-->     windows/386: github.com/Scalingo/cli/scalingo
-->     linux/arm64: github.com/Scalingo/cli/scalingo
-->     freebsd/386: github.com/Scalingo/cli/scalingo
-->   freebsd/amd64: github.com/Scalingo/cli/scalingo
-->    darwin/amd64: github.com/Scalingo/cli/scalingo
-->   openbsd/amd64: github.com/Scalingo/cli/scalingo
-->     openbsd/386: github.com/Scalingo/cli/scalingo
-->    darwin/arm64: github.com/Scalingo/cli/scalingo
-->   windows/amd64: github.com/Scalingo/cli/scalingo
-->       linux/386: github.com/Scalingo/cli/scalingo

Binaries compilation finished, archiving them
--> Create the archive for scalingo_darwin_amd64
--> Create the archive for scalingo_darwin_arm64
--> Create the archive for scalingo_freebsd_386
--> Create the archive for scalingo_freebsd_amd64
--> Create the archive for scalingo_linux_386
--> Create the archive for scalingo_linux_amd64
--> Create the archive for scalingo_linux_arm64
--> Create the archive for scalingo_openbsd_386
--> Create the archive for scalingo_openbsd_amd64
--> Create the archive for scalingo_windows_386.exe
--> Create the archive for scalingo_windows_amd64.exe
 emichon@biniou  ~/Documents/Scalingo/golang/src/github.com/Scalingo/cli   fix/739/gox ±✚  ll bin/1.24.0 
total 91M
drwxrwxr-x 2 emichon emichon 4.0K Jul 22 16:24 scalingo_1.24.0_darwin_amd64
-rw-rw-r-- 1 emichon emichon 8.2M Jul 22 16:24 scalingo_1.24.0_darwin_amd64.zip
drwxrwxr-x 2 emichon emichon 4.0K Jul 22 16:24 scalingo_1.24.0_darwin_arm64
-rw-rw-r-- 1 emichon emichon 8.0M Jul 22 16:24 scalingo_1.24.0_darwin_arm64.zip
drwxrwxr-x 2 emichon emichon 4.0K Jul 22 16:24 scalingo_1.24.0_freebsd_386
-rw-rw-r-- 1 emichon emichon 8.3M Jul 22 16:24 scalingo_1.24.0_freebsd_386.zip
drwxrwxr-x 2 emichon emichon 4.0K Jul 22 16:24 scalingo_1.24.0_freebsd_amd64
-rw-rw-r-- 1 emichon emichon 8.4M Jul 22 16:24 scalingo_1.24.0_freebsd_amd64.zip
drwxrwxr-x 2 emichon emichon 4.0K Jul 22 16:24 scalingo_1.24.0_linux_386
-rw-rw-r-- 1 emichon emichon 8.3M Jul 22 16:24 scalingo_1.24.0_linux_386.tar.gz
drwxrwxr-x 2 emichon emichon 4.0K Jul 22 16:24 scalingo_1.24.0_linux_amd64
-rw-rw-r-- 1 emichon emichon 8.4M Jul 22 16:24 scalingo_1.24.0_linux_amd64.tar.gz
drwxrwxr-x 2 emichon emichon 4.0K Jul 22 16:24 scalingo_1.24.0_linux_arm64
-rw-rw-r-- 1 emichon emichon 7.9M Jul 22 16:24 scalingo_1.24.0_linux_arm64.tar.gz
drwxrwxr-x 2 emichon emichon 4.0K Jul 22 16:24 scalingo_1.24.0_openbsd_386
-rw-rw-r-- 1 emichon emichon 8.3M Jul 22 16:24 scalingo_1.24.0_openbsd_386.zip
drwxrwxr-x 2 emichon emichon 4.0K Jul 22 16:24 scalingo_1.24.0_openbsd_amd64
-rw-rw-r-- 1 emichon emichon 8.3M Jul 22 16:24 scalingo_1.24.0_openbsd_amd64.zip
drwxrwxr-x 2 emichon emichon 4.0K Jul 22 16:24 scalingo_1.24.0_windows_386
-rw-rw-r-- 1 emichon emichon 8.6M Jul 22 16:24 scalingo_1.24.0_windows_386.zip
drwxrwxr-x 2 emichon emichon 4.0K Jul 22 16:24 scalingo_1.24.0_windows_amd64
-rw-rw-r-- 1 emichon emichon 8.6M Jul 22 16:24 scalingo_1.24.0_windows_amd64.zip

Fix #739

I wonder if it can fix #609 or #735?

  • Add a changelog entry in the section "To Be Released" of CHANGELOG.md

@EtienneM EtienneM force-pushed the fix/739/gox branch 3 times, most recently from b473787 to 7c3c95f Compare July 22, 2022 14:30
@EtienneM EtienneM marked this pull request as ready for review July 22, 2022 14:30
Copy link
Member

@curzolapierre curzolapierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As much as I like this tool and its implementation, I am not sure that it solves the above mentioned issues, at least the M1 one.
Because on #609, the issue seems to be related to the installation path cf: #611

./dists/make-release.sh -v ${{ steps.tag_name.outputs.TAG_NAME }}

- name: Release the new version
if: startsWith(github.ref, 'refs/tags/')
uses: softprops/action-gh-release@v1
with:
body: Please refer to the [CHANGELOG.md](https://github.com/Scalingo/cli/blob/${{ steps.tag_name.outputs.TAG_NAME }}/CHANGELOG.md) file.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would like to we want to remove it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry, I should have explained it before assigning you the review. I want to test if, when the body is empty, it uses the GitHub feature of automatically generating the changelog (https://docs.github.com/en/repositories/releasing-projects-on-github/automatically-generated-release-notes)

@EtienneM EtienneM enabled auto-merge July 25, 2022 12:03
@EtienneM EtienneM requested a review from curzolapierre July 25, 2022 12:03
@EtienneM EtienneM merged commit 74a8577 into master Jul 25, 2022
@EtienneM EtienneM deleted the fix/739/gox branch July 25, 2022 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace custom dists/make-reease.sh with gox Add support for the new Apple M1 architecture
2 participants