Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(install.sh): better error message if fails to get the version #748

Merged
merged 4 commits into from
Jul 22, 2022
Merged

fix(install.sh): better error message if fails to get the version #748

merged 4 commits into from
Jul 22, 2022

Conversation

EtienneM
Copy link
Member

@EtienneM EtienneM commented Jul 22, 2022 •
edited
Loading

Fix #714

  • Add a changelog entry in the section "To Be Released" of CHANGELOG.md

@EtienneM EtienneM changed the title docs(install.sh): better error message if fails to get the version fix(install.sh): better error message if fails to get the version Jul 22, 2022
@EtienneM EtienneM force-pushed the fix/714/install_errors branch from b006db9 to 576ff9d Compare July 22, 2022 15:08
@EtienneM EtienneM marked this pull request as ready for review July 22, 2022 15:08
@EtienneM EtienneM enabled auto-merge July 22, 2022 15:08
@EtienneM EtienneM force-pushed the fix/714/install_errors branch from 576ff9d to 84e7d86 Compare July 22, 2022 15:09
@EtienneM EtienneM requested a review from brandon-welsch July 22, 2022 15:09
brandon-welsch
brandon-welsch approved these changes Jul 22, 2022
View reviewed changes
Copy link
Member

@brandon-welsch brandon-welsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks 🤗

@EtienneM EtienneM merged commit 06da2b2 into master Jul 22, 2022
@EtienneM EtienneM deleted the fix/714/install_errors branch July 22, 2022 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandon-welsch brandon-welsch brandon-welsch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[install.sh] Better errors management of download and installation of the CLI
2 participants
@EtienneM @brandon-welsch