Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(appdetect) Do not crash if the git config has a remote without any URL #755

Merged
merged 1 commit into from
Aug 2, 2022
Merged

fix(appdetect) Do not crash if the git config has a remote without any URL #755

merged 1 commit into from
Aug 2, 2022

Conversation

johnsudaar
Copy link
Contributor

Fix #754

  • Add a changelog entry in the section "To Be Released" of CHANGELOG.md

@johnsudaar johnsudaar requested a review from EtienneM August 2, 2022 15:43
EtienneM
EtienneM approved these changes Aug 2, 2022
View reviewed changes
Copy link
Member

@EtienneM EtienneM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has it been reported by a customer?! 😲

@johnsudaar
Copy link
Contributor Author

Before:
2022-08-02_17-46

After:
2022-08-02_17-46_1

Has it been reported by a customer?! astonished

Yes

@johnsudaar johnsudaar force-pushed the fix/754/do_not_crash_on_weird_git_config branch from c10fa38 to 949b2c3 Compare August 2, 2022 15:49
@johnsudaar johnsudaar merged commit 060aac8 into master Aug 2, 2022
@johnsudaar johnsudaar deleted the fix/754/do_not_crash_on_weird_git_config branch August 2, 2022 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EtienneM EtienneM EtienneM approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[App Detection] If a remote has no URL, the CLI will crash when trying to auto detect the app name
3 participants
@johnsudaar @EtienneM @john-scalingo