Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(workflows/publish): split in two jobs #757

Merged
merged 3 commits into from
Aug 5, 2022
Merged

feat(workflows/publish): split in two jobs #757

merged 3 commits into from
Aug 5, 2022

Conversation

EtienneM
Copy link
Member

@EtienneM EtienneM commented Aug 3, 2022 •
edited
Loading

The release job is executed after tests, if it's successful.

Based on this doc: https://docs.github.com/en/actions/using-workflows/about-workflows#creating-dependent-jobs

@EtienneM EtienneM marked this pull request as ready for review August 3, 2022 14:04
@EtienneM EtienneM enabled auto-merge August 3, 2022 14:04
@EtienneM EtienneM requested a review from curzolapierre August 3, 2022 14:04
@EtienneM EtienneM mentioned this pull request Aug 3, 2022
Merged
curzolapierre
curzolapierre approved these changes Aug 5, 2022
View reviewed changes
Copy link
Member

@curzolapierre curzolapierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@EtienneM EtienneM merged commit e9a7c2b into master Aug 5, 2022
@EtienneM EtienneM deleted the fix/actions branch August 5, 2022 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curzolapierre curzolapierre curzolapierre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EtienneM @curzolapierre