Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(db): environment variable name is customizable #759

Merged
merged 8 commits into from
Aug 5, 2022
Merged

feat(db): environment variable name is customizable #759

merged 8 commits into from
Aug 5, 2022

Conversation

EtienneM
Copy link
Member

@EtienneM EtienneM commented Aug 4, 2022 •
edited
Loading

@johnsudaar I would like a review of what I did for MongoDB console, and if it's LGTM I just need to propagate the same change to all database types

Fix #387

  • Add a changelog entry in the section "To Be Released" of CHANGELOG.md

@EtienneM EtienneM requested a review from johnsudaar August 4, 2022 13:36
johnsudaar
johnsudaar reviewed Aug 4, 2022
View reviewed changes
Copy link
Contributor

@johnsudaar johnsudaar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's really cool !
Would you be OK to implement it on every database types ?
Edit: Facepalm forget this question :)

@EtienneM EtienneM force-pushed the fix/387/db-console_env branch from 25509e6 to 9c8e596 Compare August 4, 2022 14:50
@EtienneM EtienneM marked this pull request as ready for review August 4, 2022 14:50
@EtienneM EtienneM requested a review from johnsudaar August 4, 2022 14:55
@EtienneM EtienneM enabled auto-merge August 4, 2022 14:56
@EtienneM EtienneM requested a review from curzolapierre August 5, 2022 09:32
curzolapierre
curzolapierre approved these changes Aug 5, 2022
View reviewed changes
Copy link
Member

@curzolapierre curzolapierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EtienneM EtienneM merged commit bfccc71 into master Aug 5, 2022
@EtienneM EtienneM deleted the fix/387/db-console_env branch August 5, 2022 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curzolapierre curzolapierre curzolapierre approved these changes

@johnsudaar johnsudaar Awaiting requested review from johnsudaar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[db-console commands] it should be possible to enforce the environment variable used
3 participants
@EtienneM @johnsudaar @curzolapierre