Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: various linter offenses #920

Merged
merged 17 commits into from
Mar 27, 2023
Merged

refactor: various linter offenses #920

merged 17 commits into from
Mar 27, 2023

Conversation

EtienneM
Copy link
Member

  • Add a changelog entry in the section "To Be Released" of CHANGELOG.md

@EtienneM EtienneM self-assigned this Mar 24, 2023
@EtienneM EtienneM force-pushed the fix/linter_offenses branch from 845f5ca to 6d3b8ac Compare March 24, 2023 14:03
@EtienneM EtienneM requested a review from ipfaze March 24, 2023 14:05
@EtienneM EtienneM marked this pull request as ready for review March 24, 2023 14:05
ipfaze

This comment was marked as duplicate.

Sign in to view

ipfaze

This comment was marked as duplicate.

Sign in to view

ipfaze
ipfaze approved these changes Mar 24, 2023
View reviewed changes
Copy link
Contributor

@ipfaze ipfaze left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, even if you need to add more linter fixes 😅

@EtienneM EtienneM force-pushed the fix/linter_offenses branch from 26a6433 to c1855b0 Compare March 27, 2023 09:04
@EtienneM EtienneM force-pushed the fix/linter_offenses branch from c1855b0 to 3c834ab Compare March 27, 2023 09:16
@EtienneM EtienneM merged commit cc3794c into master Mar 27, 2023
@EtienneM EtienneM deleted the fix/linter_offenses branch March 27, 2023 13:18
@EtienneM EtienneM restored the fix/linter_offenses branch May 31, 2023 06:48
@EtienneM EtienneM deleted the fix/linter_offenses branch May 31, 2023 06:48
@EtienneM EtienneM mentioned this pull request May 31, 2023
Merged
1 task
EtienneM added a commit that referenced this pull request May 31, 2023
@EtienneM
revert: refactor: various linter offenses
d53d356 
Reverts PR #920

Fix #957
EtienneM added a commit that referenced this pull request May 31, 2023
@EtienneM
revert: refactor: various linter offenses
9a035d1 
Reverts PR #920

Fix #957
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ipfaze ipfaze ipfaze approved these changes

Assignees

@EtienneM EtienneM

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EtienneM @ipfaze