feat(review-apps) wording changes #922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the rendering technique Signed-off-by: Yohann Bacha <yohann.bacha@scalingo.com>
guillaume-sc
suggested changes
Mar 30, 2023
guillaume-sc
suggested changes
Mar 30, 2023
Signed-off-by: Yohann Bacha <yohann.bacha@scalingo.com>
guillaume-sc
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need to add changelog entries
Fixes #921
I also changed the way the integration settings are displayed, using go templates. I think this is much clearer than doing it programmatically, if you have some returns let me know
(sorry etienne, github does not allow me to remove you from the reviewers)