docs(readme): use a PR to bump a version #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hub is deprecated
EtienneM
changed the title
gh rather than hub
ipfaze
requested changes
Oct 17, 2023
| git push --tags | ||
| gh release create v5.0.7 | ||
| git commit -m "Bump v${version}" | ||
| git push --set-upstream origin release/${version} |
There was a problem hiding this comment.
question: is it a required command? I don't remember doing this one before using gh pr create ...
There was a problem hiding this comment.
It's indeed not mandatory. gh pr create will do it if needed. I wanted it to be explicitly done in this procedure. That's how we documented it in other open source projects.
| Once the pull request merged, you can tag the new release. | ||
|
|
||
| ```sh | ||
| git tag v${version} |
There was a problem hiding this comment.
question: is it something that we can automate? Using GitHub Actions?
There was a problem hiding this comment.
I don't think so. At least it's not how we do it on other open source projects.
ipfaze
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.