Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added scm integrations types #124

Merged
merged 2 commits into from
Jul 30, 2019
Merged

Added scm integrations types #124

merged 2 commits into from
Jul 30, 2019

Conversation

brandon-welsch
Copy link
Member

Close #123

@brandon-welsch brandon-welsch requested a review from EtienneM July 30, 2019 09:22
EtienneM
EtienneM requested changes Jul 30, 2019
View reviewed changes
Copy link
Member

@EtienneM EtienneM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that I'm a pain in the ass with that kind of review, but SCM being initials, they must be upper case. This is a Go rule: https://github.com/golang/go/wiki/CodeReviewComments#initialisms

I know it's not the case in the GitHub Hook service but that's just because I'm not the one who did the first review of your PRs on this project :p

integrations.go Outdated Show resolved Hide resolved
@brandon-welsch brandon-welsch requested a review from EtienneM July 30, 2019 09:31
EtienneM
EtienneM reviewed Jul 30, 2019
View reviewed changes
integrations.go Outdated Show resolved Hide resolved
@brandon-welsch brandon-welsch force-pushed the feature/123/add_scm_integrations_types branch from ff0446d to 6dc0f97 Compare July 30, 2019 09:36
@brandon-welsch brandon-welsch requested a review from EtienneM July 30, 2019 09:36
EtienneM
EtienneM reviewed Jul 30, 2019
View reviewed changes
integrations.go Outdated Show resolved Hide resolved
@brandon-welsch brandon-welsch force-pushed the feature/123/add_scm_integrations_types branch from 6dc0f97 to bd6089a Compare July 30, 2019 09:38
@brandon-welsch brandon-welsch requested a review from EtienneM July 30, 2019 09:41
@EtienneM EtienneM merged commit d854d82 into master Jul 30, 2019
@EtienneM EtienneM deleted the feature/123/add_scm_integrations_types branch July 30, 2019 09:43
@EtienneM EtienneM mentioned this pull request Sep 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EtienneM EtienneM EtienneM approved these changes

Assignees
No one assigned
Labels
reviewable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add SCM integrations types
2 participants
@brandon-welsch @EtienneM