Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SCMIntegrationUUID field on structs #148

Merged
merged 2 commits into from
Oct 18, 2019

Conversation

brandon-welsch
Copy link
Member

Close #147

Copy link
Member

@EtienneM EtienneM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why aren't these fields useful? Aren't they returned by the API?

@brandon-welsch
Copy link
Member Author

Why aren't these fields useful? Aren't they returned by the API?

Actually the API return this field, but this PR https://github.com/Scalingo/api/pull/1591 remove this field.

Issue linked : https://github.com/Scalingo/api/issues/1583

@EtienneM
Copy link
Member

OK it makes sense now. Next time, link the issue on the API on the issue here. Otherwise it does not make any sense to me...

@EtienneM
Copy link
Member

Can you add an entry in the changelog before merging?

@Soulou Soulou merged commit d290f01 into master Oct 18, 2019
@EtienneM EtienneM deleted the fix/147/remove_scm_integration_uuid_field branch July 15, 2021 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SCM Integrations] Remove SCMIntegrationUUID from structs
3 participants