Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore previous AppsPs and rename AppsPs to AppsContainersPs #208

Merged
merged 1 commit into from
Mar 30, 2021

Conversation

EtienneM
Copy link
Member

@EtienneM EtienneM commented Mar 29, 2021

The PR #204 introduced an API change which would have require a new major release. But as stated in the Go module documentation (https://blog.golang.org/v2-go-modules):

These kinds of changes require effort by downstream users to migrate their code to the new API, so they should not be made without careful consideration that the benefits outweigh the costs

In this situation, I don't think that the benefits outweigh the costs. Hence I'm reverting the API changes so that we don't break the API anymore.

Related to OPSB-257

The PR #204 introduced an API change which would have require a new major release. But as stated in the Go module documentation (https://blog.golang.org/v2-go-modules):

> These kinds of changes require effort by downstream users to migrate their code to the new API, so they should not be made without careful consideration that the benefits outweigh the costs

In this situation, I don't think that the benefits outweigh the costs. Hence I'm reverting the API changes so that we don't break the API anymore.
@EtienneM EtienneM force-pushed the fix/OPSB-257/app_containers branch from 6fc1900 to 89e905f Compare March 29, 2021 15:36
@EtienneM EtienneM marked this pull request as ready for review March 29, 2021 15:37
@EtienneM EtienneM requested a review from Soulou March 29, 2021 15:37
Copy link
Member

@Soulou Soulou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Soulou Soulou merged commit 9740a8d into master Mar 30, 2021
@Soulou Soulou deleted the fix/OPSB-257/app_containers branch March 30, 2021 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants