feat(events) Implement event for repeated crash #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EtienneM
requested changes
Oct 11, 2021
CHANGELOG.md
Outdated
| @@ -4,6 +4,7 @@ | |||
|
|
|||
| * build(deps): bump github.com/golang-jwt/jwt/v4 from 4.0.0 to 4.1.0 [#225](https://github.com/Scalingo/go-scalingo/pull/225) | |||
| * chore: use jwt.RegistredClaims instead of jwt.StandardClaims [#227](https://github.com/Scalingo/go-scalingo/pull/227) | |||
| * feat(events) Implement event for repeated crash [#229](https://github.com/Scalingo/go-scalingo/pull/227) | |||
There was a problem hiding this comment.
typo:
Suggested change
| * feat(events) Implement event for repeated crash [#229](https://github.com/Scalingo/go-scalingo/pull/227) | |
| * feat(events): Implement event for repeated crash [#229](https://github.com/Scalingo/go-scalingo/pull/229) |
events_structs.go
Outdated
| @@ -283,7 +284,7 @@ type EventCrashType struct { | |||
| } | |||
|
|
|||
| func (ev *EventCrashType) String() string { | |||
| msg := fmt.Sprintf("container '%v' has crashed", ev.TypeData.ContainerType) | |||
| msg := fmt.Sprintf("container '%v' has crashed repeatedly", ev.TypeData.ContainerType) | |||
There was a problem hiding this comment.
I think you confused the crashed and repeated_crash event:
Suggested change
| msg := fmt.Sprintf("container '%v' has crashed repeatedly", ev.TypeData.ContainerType) | |
| msg := fmt.Sprintf("container '%v' has crashed", ev.TypeData.ContainerType) |
events_structs.go
Outdated
| } | ||
|
|
||
| func (ev *EventRepeatedCrashType) String() string { | ||
| msg := fmt.Sprintf("container '%v' has crashed", ev.TypeData.ContainerType) |
There was a problem hiding this comment.
Suggested change
| msg := fmt.Sprintf("container '%v' has crashed", ev.TypeData.ContainerType) | |
| msg := fmt.Sprintf("container '%v' has crashed repeatedly", ev.TypeData.ContainerType) |
stopostit
force-pushed
the
feat/682/event_repeated_crash
branch
from
a4bde5f to
bfc2700
Compare
EtienneM
reviewed
Oct 11, 2021
EtienneM
approved these changes
Oct 11, 2021
stopostit
force-pushed
the
feat/682/event_repeated_crash
branch
from
a48c22d to
941364a
Compare
EtienneM
reviewed
Oct 11, 2021
EtienneM
approved these changes
Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Scalingo/cli#682