feat(addon-logs-archives): add AddonLogsArchives method #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
Should I remove |
No, not yet |
EtienneM
reviewed
Nov 4, 2021
There was a problem hiding this comment.
Neither the PR title, nor the commits message respect the convention (https://karma-runner.github.io/6.3/dev/git-commit-msg.html).
sihamais
changed the title
EtienneM
approved these changes
Nov 4, 2021
|
Not yet. Actually I don’t know how to test it before merging it. Maybe by adding the method on the dependency in the CLI code but it’s ugly. Is there another way ? |
EtienneM
force-pushed
the
feat/addon-logs-archives
branch
from
2d75147 to
9e979d1
Compare
EtienneM
force-pushed
the
feat/addon-logs-archives
branch
from
9e979d1 to
2f85193
Compare
EtienneM
approved these changes
Nov 5, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to Scalingo/cli#518