Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCM integration fields #271

Merged
merged 6 commits into from
Sep 15, 2022
Merged

SCM integration fields #271

merged 6 commits into from
Sep 15, 2022

Conversation

SCedricThomas
Copy link
Contributor

fix #270

@SCedricThomas SCedricThomas self-assigned this Sep 15, 2022
EtienneM
EtienneM reviewed Sep 15, 2022
View reviewed changes
scm_integrations.go Outdated Show resolved Hide resolved
@SCedricThomas
Copy link
Contributor Author

I will merge next time... I heard from Pierre that rebasing was the good practice but it seems I didn't understood when to rebase !
The file I changed are: scm_integrations.go, app.go, common.go and examples/app_show/main.go

EtienneM
EtienneM reviewed Sep 15, 2022
View reviewed changes
common.go Outdated Show resolved Hide resolved
@SCedricThomas SCedricThomas force-pushed the feat/270/scm-integration-fields branch from 01a6547 to 549665e Compare September 15, 2022 13:02
@SCedricThomas SCedricThomas merged commit 3f3429b into master Sep 15, 2022
@SCedricThomas SCedricThomas deleted the feat/270/scm-integration-fields branch September 15, 2022 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EtienneM EtienneM EtienneM approved these changes

Assignees

@SCedricThomas SCedricThomas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add missing fields for scm integration endpoint
2 participants
@SCedricThomas @EtienneM