feat(send-signal): new function ContainersSendSignal to request the send-signal api's endpoint
#295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuentinEscudierScalingo
force-pushed
the
feat/294/new_endpoint_send_signal
branch
from
9bcff82 to
aeccae3
Compare
QuentinEscudierScalingo
changed the title
ContainersSendSignal the send-signal api's endpoint
QuentinEscudierScalingo
force-pushed
the
feat/294/new_endpoint_send_signal
branch
from
465773d to
9ed8faa
Compare
QuentinEscudierScalingo
changed the title
ContainersSendSignal the send-signal api's endpointContainersSendSignal to request the send-signal api's endpoint
EtienneM
reviewed
Dec 23, 2022
container.go
Outdated
| @@ -43,3 +43,18 @@ func (c *Client) ContainersStop(ctx context.Context, appName, containerID string | |||
|
|
|||
| return nil | |||
| } | |||
|
|
|||
| func (c *Client) ContainersSendSignal(ctx context.Context, app string, signal string, container string) error { | |||
There was a problem hiding this comment.
naming: I'm not completely convinced by the variable name container. Is it a name (e.g. web-1) or an ID (e.g. 5c9b95d201dcea2f34d496a3)? Depending on the answer I would name it containerName or containerID.
There was a problem hiding this comment.
It's a containerName, reasons why it's a docker_name instead of a docker_id is explained here https://github.com/Scalingo/api/pull/2096#discussion_r1057484461
EtienneM
reviewed
Dec 28, 2022
EtienneM
approved these changes
Dec 28, 2022
QuentinEscudierScalingo
deleted the
feat/294/new_endpoint_send_signal
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #294