Merge pull request #19 from Scalingo/fix/18/plugin-system

Use pointer instead of structure as we need to keep the state of data Fixes #18
Scalingo · Nov 11, 2017 · c9d477b · c9d477b
2 parents 792fbdb + 37d1808
commit c9d477b
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,11 @@
 # Changelog
 
+## v1.0.1
+
+### logger
+
+* Fix plugin system, use pointer instead of value for manager
+
 ## v1.0.0
 
 ### mongo (api change)

diff --git a/logger/plugin.go b/logger/plugin.go
@@ -6,10 +6,10 @@ import (
 	"github.com/sirupsen/logrus"
 )
 
-var plugins = PluginManager{}
+var plugins = &PluginManager{}
 
 // Plugins is the entrypoint to the global PluginManager
-func Plugins() PluginManager {
+func Plugins() *PluginManager {
 	return plugins
 }
 
@@ -25,7 +25,7 @@ type PluginManager struct {
 }
 
 // RegisterPlugin add a plugin to the current plugin list, if the plugin is already in memory, he will skip the add part
-func (m PluginManager) RegisterPlugin(plugin Plugin) {
+func (m *PluginManager) RegisterPlugin(plugin Plugin) {
 	m.lock.Lock()
 	defer m.lock.Unlock()
 
@@ -39,7 +39,7 @@ func (m PluginManager) RegisterPlugin(plugin Plugin) {
 }
 
 // Hooks return all the hooks generated by the plugins
-func (m PluginManager) Hooks() []logrus.Hook {
+func (m *PluginManager) Hooks() []logrus.Hook {
 	m.lock.Lock()
 	defer m.lock.Unlock()