Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump v1.0.4 #18

Closed
wants to merge 1 commit into from
Closed

Bump v1.0.4 #18

wants to merge 1 commit into from

Conversation

sc-david-voisin
Copy link
Contributor

No description provided.

@sc-david-voisin sc-david-voisin self-assigned this Aug 28, 2024
EtienneM
EtienneM reviewed Aug 28, 2024
View reviewed changes
Copy link
Member

@EtienneM EtienneM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: with changes in the behaviour of the password generation, I think it should be a new minor version (v1.1.0), what do you think?

@sc-david-voisin
Copy link
Contributor Author

suggestion: with changes in the behaviour of the password generation, I think it should be a new minor version (v1.1.0), what do you think?

I agree.
These changes deserve a minor version. I close this PR and bump a new one.

@sc-david-voisin
Copy link
Contributor Author

Cancelled for a bump to 1.1.0 version instead.

@sc-david-voisin sc-david-voisin deleted the release/1.0.4 branch August 28, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EtienneM EtienneM EtienneM left review comments

Assignees

@sc-david-voisin sc-david-voisin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sc-david-voisin @EtienneM