Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ressource): fix terraform import SCM repo link #84

Merged
merged 6 commits into from
Sep 21, 2022

Conversation

QuentinEscudierScalingo
Copy link
Contributor

Currently, the API is not returning the source field.
I'm waiting for an answer from the UFS team: https://scalingo.slack.com/archives/C6GE4JP3L/p1663340891484649

Fix #83

Copy link
Member

@Soulou Soulou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually we don't want to give the ScmRepoLink ID

Why:

There is a 1-1 relationship beween an app and a SCM repolink. So if you know the app, you know the RepoLink.

So to simplify the import API, only the app ID should be given.

@QuentinEscudierScalingo QuentinEscudierScalingo force-pushed the fix/83/fix_terraform_import_SCM_repo_link branch from d59561a to 8200aa2 Compare September 19, 2022 10:32
@Soulou
Copy link
Member

Soulou commented Sep 21, 2022

Bump go-scalingo

… correctly store AppID of repolink instead when imported from app name, add an example of scm_repo_link, allow filtering data source SCM Integration by scm_type or url
@Soulou Soulou enabled auto-merge September 21, 2022 13:03
@Soulou Soulou merged commit 1e0b6b5 into master Sep 21, 2022
@Soulou Soulou deleted the fix/83/fix_terraform_import_SCM_repo_link branch September 21, 2022 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SCM Repo Link] Fix terraform import
3 participants