Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate buffer writes for uniform blocks #179

Open
3 tasks
ScanMountGoat opened this issue Jul 15, 2020 · 0 comments
Open
3 tasks

Validate buffer writes for uniform blocks #179

ScanMountGoat opened this issue Jul 15, 2020 · 0 comments
Labels
enhancement New or improved feature unit test This feature lacks unit tests

Comments

@ScanMountGoat
Copy link
Owner

ScanMountGoat commented Jul 15, 2020

Buffers will most likely be initialized once and then bound to shaders many times, so there is little performance impact for doing these checks. Writes should only be checked to ensure they don't exceed the length of the variable in the uniform blocks. Writing a byte[3] to a float should still be valid, for example.

  • check if write would exceed the buffer's storage
  • check if write would exceed the size of the uniform variable
  • check writes for arrays
@ScanMountGoat ScanMountGoat added enhancement New or improved feature unit test This feature lacks unit tests labels Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New or improved feature unit test This feature lacks unit tests
Projects
None yet
Development

No branches or pull requests

1 participant