🐛 Fix potential crash encrypting with Modcrypt, invalid header hash generation and corruption of Modcrypt after arm9 changes #36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix several bugs related to Modcrypt (d)encryption and ROM header hash generation, especially after changes on the arm9 and/or its code parameters (such as compression length):
BigInteger
are signed values and after the bitwise OR operation, the sign may be affected changing a 22-bytes length number to a 6-bytes length number.Also fix the build by installing .NET 6 SDK and bumping .NET 8 SDK.
Quality check list
developer certificate of origin
Acceptance criteria
The Modcrypt key generation does not fail.
Every hash of the encrypted content is valid after changing the arm9 content.
Follow-up work
None
Example
N/A