Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the red color in ViewRenderable display as orange #252

Closed
lgz800 opened this issue Dec 22, 2021 · 4 comments
Closed

the red color in ViewRenderable display as orange #252

lgz800 opened this issue Dec 22, 2021 · 4 comments
Labels

Comments

@lgz800
Copy link

lgz800 commented Dec 22, 2021

hi
I use sceneform 1.20.2 version, it depend on filament 1.12.8 version
I made a ViewRenderable inlucde a red circle image. but in screen it display as orange.

when i change filament into 1.12.1 version, the color will be well.

And filament 1.12.2 version is same with filament 1.12.8.
Is there any adaptation problem? Thank you :)

imageview_card,xml is:

<?xml version="1.0" encoding="utf-8"?>
<ImageView xmlns:android="http://schemas.android.com/apk/res/android"
    xmlns:tools="http://schemas.android.com/tools"
    android:tag="image"
    android:layout_width="wrap_content"
    android:layout_height="wrap_content"
    android:src="@drawable/ad_act_3"
    android:background="#ff0000"
    tools:ignore="MissingDefaultResource">
</ImageView>

ad_act_3 is:

create viewrenderable codes is:

ViewRenderable.builder()
                .setView(this, R.layout.imageview_card)
                .build()
                .thenAccept(
                        (renderable) -> {
                            renderable.setSizer(new FixedHeightViewSizer(0.5f));
                            ViewRenderable imageRenderable = renderable;
                            imageRenderable.setVerticalAlignment(ViewRenderable.VerticalAlignment.CENTER);
                            imageRenderable.setHorizontalAlignment(ViewRenderable.HorizontalAlignment.CENTER);
                            MainActivity activity = weakActivity.get();
                            if (activity != null) {
                                activity.model = renderable;
                            }
                        })
                .exceptionally(
                        (throwable) -> {
                            throw new AssertionError("Could not load plane card view.", throwable);
                        });
@RGregat
Copy link
Contributor

RGregat commented Dec 23, 2021

Maybe something has changed again on the tone mapping. The current version of Filament is 1.15.1 which is on our to do list for an upcomming update.

@grassydragon
Copy link
Contributor

This solution can be used for now to get the correct colors: #295 (comment)

@RGregat
Copy link
Contributor

RGregat commented Feb 23, 2022

@lgz800 do you have still the problem? Can you test your usecase with the latest version of SceneForm?

@ThomasGorisse
Copy link
Collaborator

Fixed: #311

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants