generate command does not execute hooks

[zaro0508]

I use the !cmd hook in my main and dependent sceptre files to download shared templates. In my case the sceptre generate command fails because it does not run the hook to download the needed CFN template files for sceptre to process. Is there a way to force the generate command to execute hooks? Just a note that when I run the launch command the hooks are executed.

Here's a simple example:

in templates/noop.yaml

Description: noop template
AWSTemplateFormatVersion: 2010-09-09
Resources:
  touchNothing:
    Type: AWS::CloudFormation::WaitConditionHandle

in config/prod/A.yaml

template_path: "noop.yaml"
stack_name: "A"
hooks:
  before_create:
    - !cmd "echo test before_create for A"
  before_update:
    - !cmd "echo test before_update for A"

in config/prod/main.yaml

template_path: "noop.yaml"
stack_name: "main"
dependencies:
  - "prod/A.yaml"
hooks:
  before_create:
    - !cmd "echo test before_create for main"
  before_update:
    - !cmd "echo test before_update for main"

execute generate:

sceptre --debug --output yaml generate prod/main.yaml

*Note: the output does NOT contain test before_create for A and test before_create for main which means the hooks did not get executed.

execute launch:

sceptre --output yaml launch prod/main.yaml 

*Note: the hooks do get executed and the output does contain test before_create for A and test before_create for main

[ngfgrant]

Maybe worth a quick PoC: https://github.com/Sceptre/sceptre/blob/master/sceptre/plan/actions.py#L564 suggests that generate won't respond to hooks because it is not decorated with the @add_stack_hooks decorator like launch is (https://github.com/Sceptre/sceptre/blob/master/sceptre/plan/actions.py#L176).

Could you fire up a branch that has that change to see if it works without much hassle?

[zaro0508]

thanks @ngfgrant, adding the decorator works.