[Resolves #1072] replace setup.py with pip #1075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sceptre ver 2.6.1 introduced the sceptre-cmd-resolver as a core resolver however it looks like the setup.py command to install sceptre in the dockerfile does not seem to install that dependency. The pip command will install sceptre with dependencies so we switch to install sceptre with pip.
craighurley
approved these changes
Aug 2, 2021
tarkatronic
approved these changes
Aug 2, 2021
There was a problem hiding this comment.
If you've tested this and it's working for you, I'll trust that. I'm a little concerned though as to why it didn't work previously. The python setup.py install should work the same.
Of course, if we are able to get #1035 though, then this all becomes a non-issue. 😄
|
hmm, interesting @tarkatronic. I did test and as for #1035 i think we should save that for a v2.7.x release. |
zxiiro
approved these changes
Aug 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sceptre ver 2.6.1 introduced the sceptre-cmd-resolver as a core resolver
however it looks like the setup.py command to install sceptre in the
dockerfile does not seem to install that dependency.
The pip command will install sceptre with dependencies so we switch to
install sceptre with pip.