[Resolves #1179] cloudformation disable-rollback option #1282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow user to disable a cloudformation rollback on a sceptre deployment.
zaro0508
changed the title
jfalkenstein
requested changes
Dec 28, 2022
There was a problem hiding this comment.
We also should add integration tests that test something along the lines that:
When a stack that creates two resources, one properly configured and one improperly configured gets deployed with disable rollback, once it's launched with disable-rollback, the properly configured resource still exists.
dboitnot
suggested changes
Dec 29, 2022
Co-authored-by: Dan Boitnott <dboitnot@gmail.com> Co-authored-by: Jon Falkenstein <77296393+jfalkenstein@users.noreply.github.com>
jfalkenstein
reviewed
Jan 8, 2023
jfalkenstein
reviewed
Jan 8, 2023
jfalkenstein
reviewed
Jan 8, 2023
jfalkenstein
reviewed
Jan 8, 2023
zaro0508
requested review from
dboitnot and
jfalkenstein
and removed request for
dboitnot
jfalkenstein
reviewed
Jan 9, 2023
jfalkenstein
reviewed
Jan 9, 2023
jfalkenstein
approved these changes
Jan 10, 2023
dboitnot
reviewed
Jan 11, 2023
| @@ -24,9 +24,16 @@ | |||
| is_flag=True, | |||
| help="If set, will delete all stacks in the command path marked as obsolete.", | |||
| ) | |||
| @click.option( | |||
| "--disable-rollback/--enable-rollback", | |||
| default=False, | |||
There was a problem hiding this comment.
Unless I'm missing something, I think we might want default=None here. That way if the user doesn't specify --disable... or --enable... it will fall back to whatever's in the StackConfig (or False if nothing's there).
There was a problem hiding this comment.
Is this something for @zaro0508 to deal with or should I open another PR?
There was a problem hiding this comment.
If you have opportunity and time to get it done, I say go for it. I'm not sure what @zaro0508 has going on over the next few days and if he'll have time. (I'll let him speak for himself, though).
There was a problem hiding this comment.
yes, please. would love to see a PR from you @dboitnot 😄
There was a problem hiding this comment.
Added #1288. Since it was a one-word update I tried doing it through the GitHub interface.
9 tasks
jfalkenstein
added a commit
that referenced
this pull request
Feb 11, 2023
## 4.0.0 (2023.02.08) ### Added - [Resolve #1283] Introducing `sceptre_role`, `cloudformation_service_role` (#1295) - These are just iam_role and role_arn renamed to be a lot clearer. See "Deprecations" below. ### Changed - [Resolve #1299] Making the ConnectionManager a more "friendly" interface for hooks, resolvers, and template handlers (#1287, #1300) - This creates adds the public `get_session()` and `create_session_environment_variables()` methods to make AWS interactions easier and more consistent with individual stack configurations for iam_role, profile, and region configurations. - The `call()` method now properly distinguishes between default stack configurations for profile, region, and `sceptre_role` and setting those to `None` to nullify them. - Preventing Duplicate Deprecation Warnings from being emitted (#1297) #### _Potentially_ Breaking Changes - The !cmd hook now invokes the passed command using the AWS environment variables that correspond with the stack's IAM configurations (i.e. iam_role, profile, region). This means that the hook will operate the same as every other part of Sceptre and regard how the stack is configured. This should make it easier to invoke other tools like AWS CLI with your hooks. However, if your project is setting environment variables with the intent to change how the command authenticates with AWS (such as a different token, profile, or region), these environment variables will be overridden. To maintain the same functionality, you should prefix your command with `export AWS_SESSION_TOKEN={{environment_variable.AWS_SESSION_TOKEN}} &&` (or whatever other environment variable(s) you need to explicitly set). ### Deprecations - [Resolve #1283] Deprecating `iam_role`, `role_arn`, and `template_path` (#1295) - `iam_role` and `role_arn` have been aliased to `sceptre_role` and `cloudformation_service_role`. Using these fields will result in a DeprecationWarning. - `template_path` has actually been slated for removal since v2.7. `template` should be used instead. Using `template_path` will result in a DeprecationWarning. - All three deprecated StackConfig fields will be removed in v5.0.0. ## 3.3.0 (2023.02.06) ### Added - [Resolve #1261] Add coloured differ (#1260) - Implements coloured diffs for the diff (difflib) command. Responds to --no-color. - [Resolves #1271] Extend stack colourer to include "IMPORT" states (#1272) - [Resolves #1179] cloudformation disable-rollback option (#1282) - Allow user to disable a cloudformation rollback on a sceptre deployment. ### Changed - [Resolve #1098] Deploy docker container to sceptreorg repo (#1265) - Deploy sceptre docker images to dockerhub sceptreorg repo instead of cloudreach repo - Updating Setuptools and wheel versions to avert security issues - [Resolve #1293] Improve the Stack Config Jinja Syntax Error Message to include the Stack Name (#1294) - [Resolves #1267] Improve the Stack Config Jinja Error Message to include the Stack Name (#1269) ### Fixed - [Resolve #1273] Events start from response time (#1275) - Resolves #1273 by starting event filtering from the timestamp returned in the AWS response headers rather than relying on the workstation clock. - [Resolve #1253] Failed downloads raise error (#1277) - Throwing an informative error when the template fails to download instead of passing the error message to CloudFormation. - [Resolves #1179] Changed disable-rollback default to None (#1288) - We want the default value to be None to represent "Do whatever's configured in the StackConfig" and True/False will override the StackConfig. ### Nonfunctional - Add tweet-release to CircleCI config (#1259) - [Resolves #1276] Adopt Black Auto-formatter (#1278) - Reformatting all Python files using the Black code formatter. This also delivers a new function for generating `__repr__` methods which was needed to deal with a line-too-long issue in Template. Per discussion in #1276 this PR also disables E203 in flake8. - Update sceptre-circleci docker image (#1284) - Update to build and test with a docker image that's based on the official circleci python docker image. - [Resolve #1264] Updating the CDK docs to point to the new sceptre-cdk-handler (#1285) - This updates our docs to no longer reference the old CDK approach (which didn't work with CDK assets). In its place, it references the new sceptre-cdk-handler package that covers that functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow user to disable a cloudformation rollback on a Sceptre deployment.