-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Resolves #894] Switch to using poetry #1323
Conversation
@jfalkenstein i got unit tests working for python 3.7 now as well. |
I hope to test this some evening this week. Sorry for the delay. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the troposphere extra is implemented improperly (or at least weirdly). It should also be a dev dependency.
Also, the github pull request template references running make test
.
Finally, I think it's a pretty significant loss with losing the makefile. I really feel like the makefile didn't have to be removed and it should have just been updated.
It also appears as if integration tests are failing on this. |
* restore makefile and update with poetry commands * make tests run in parallel on CI * switch docs packages to be an extras dependency
I'll try to test this out tonight. |
run sphinx-apidoc instead of make Co-authored-by: Jon Falkenstein <77296393+jfalkenstein@users.noreply.github.com>
This looks good to me now. I'm running integration tests on it now. Assuming all tests pass, I'll approve. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations.
The intent here is to change the tooling over to use poetry instead of
setuptools
.This is building on the work that was started by @tarkatronic in PR #1035
Some important things to note:
*.json
that had to be manually included by setuptools.twine
is no longer necessary as we can simply usepoetry publish
..gitattributes
) file to treat thepoetry.lock
file as binary. This is a fairly standard practice, also followed in the JS community with thepackage-lock.json
file. This does two primary things: