Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Resolves #1388] Handle failures gracefully in stack outputs #1391

Merged
merged 15 commits into from
Feb 8, 2024

Conversation

alex-harvey-z3q
Copy link
Contributor

@alex-harvey-z3q alex-harvey-z3q commented Nov 27, 2023

This adds exception handling in the case of failures to parse the given arguments to !stack_output and !stack_output_external.

PR Checklist

  • Wrote a good commit message & description [see guide below].
  • Commit message starts with [Resolve #issue-number].
  • Added/Updated unit tests.
  • Added/Updated integration tests (if applicable).
  • All unit tests (poetry run tox) are passing.
  • Used the same coding conventions as the rest of the project.
  • The new code passes pre-commit validations (poetry run pre-commit run --all-files).
  • The PR relates to only one subject with a clear title.
    and description in grammatically correct, complete sentences.

Approver/Reviewer Checklist

  • Before merge squash related commits.

Other Information

Guide to writing a good commit

This adds a unit test demonstrating the behaviour of a badly-formatted
resolver.
This adds exception handling in the case of failures to parse the given
arguments to !stack_output and !stack_output_external.
@iainelder
Copy link
Contributor

How does it look when you run it with a real template? Does it print a stack trace, or something more readable?

@iainelder
Copy link
Contributor

If you provide a minimal Sceptre project setup that invokes the error, I'll run it at the command line to see how it feels compared to the original behavior.

Copy link
Contributor

@jfalkenstein jfalkenstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. Thanks for your work on this!

@alex-harvey-z3q alex-harvey-z3q changed the base branch from ah/1388-add-test to master January 19, 2024 09:11
@zaro0508 zaro0508 closed this Jan 26, 2024
@zaro0508 zaro0508 deleted the ah/1388-bugfix branch January 26, 2024 21:07
@zaro0508 zaro0508 restored the ah/1388-bugfix branch January 26, 2024 21:07
@zaro0508 zaro0508 reopened this Jan 26, 2024
@zaro0508 zaro0508 closed this Jan 26, 2024
@zaro0508 zaro0508 deleted the ah/1388-bugfix branch January 26, 2024 21:10
@zaro0508 zaro0508 restored the ah/1388-bugfix branch January 26, 2024 21:11
@zaro0508 zaro0508 reopened this Jan 26, 2024
Copy link
Contributor

@zaro0508 zaro0508 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/integration-tests

@zaro0508 zaro0508 closed this Feb 8, 2024
@zaro0508 zaro0508 deleted the ah/1388-bugfix branch February 8, 2024 19:17
@zaro0508 zaro0508 restored the ah/1388-bugfix branch February 8, 2024 19:18
@zaro0508 zaro0508 reopened this Feb 8, 2024
@zaro0508 zaro0508 merged commit a9c83b0 into master Feb 8, 2024
12 checks passed
@zaro0508 zaro0508 deleted the ah/1388-bugfix branch February 8, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants