Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Resolves #1460] Update NO_ECHO_REPLACEMENT #1461

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

p7-mark
Copy link
Contributor

@p7-mark p7-mark commented Apr 29, 2024

Update NO_ECHO_REPLACEMENT to remove some false positives when calling sceptre diff on stacks containing parameters with NoEcho: True.

PR Checklist

  • Wrote a good commit message & description [see guide below].
  • Commit message starts with [Resolve #issue-number].
  • All unit tests (poetry run tox) are passing.
  • Used the same coding conventions as the rest of the project.
  • The new code passes pre-commit validations (poetry run pre-commit run --all-files).
  • The PR relates to only one subject with a clear title.
    and description in grammatically correct, complete sentences.

Approver/Reviewer Checklist

  • Before merge squash related commits.

Other Information

Guide to writing a good commit

@zaro0508
Copy link
Contributor

thanks for the contribution @p7-mark

@zaro0508 zaro0508 merged commit a6952c7 into Sceptre:master Apr 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants