[Resolve #915] Support ChangeSetType CREATE #1469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds logic supporting the case of creating change sets for a stack that does not already exist, i.e. specifying ChangeSetType of CREATE. https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/cloudformation/client/create_change_set.html
This reverts commit 906005d.
for more information, see https://pre-commit.ci
alex-harvey-z3q
changed the title
alex-harvey-z3q
commented
Jun 1, 2024
zaro0508
requested changes
Jun 12, 2024
zaro0508
requested changes
Jun 13, 2024
There was a problem hiding this comment.
Integration tests are failing for this PR, https://github.com/Sceptre/sceptre/actions/runs/9507089977/job/26205762444
|
@zaro0508 integration test fixed: |
zaro0508
requested changes
Jun 17, 2024
zaro0508
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds logic supporting the case of creating change sets for a stack that does not already exist. That is, it adds support for change sets of ChangeSetType CREATE. https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/cloudformation/client/create_change_set.html
To add some context, there is no obvious reason why Sceptre does not already support change sets of type CREATE since the logic for detecting stack status already exists for the
launchcommand. The project's initial commit already has this inconsistency and essentially the same code. It is probably an oversight.The changes have already been tested by Rohit S in this Slack thread
https://og-aws.slack.com/archives/C01JNN8RGBB/p1716869822031499
In addition, it is necessary to add logic to handle the
REVIEW_IN_PROGRESSstate, both for the case of thelaunchandcreateaction.https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/using-cfn-describing-stacks.html
Creation of a change set on a non-existent stack actually creates a stack and places it into the
REVIEW_IN_PROGRESSstate. If Sceptre is then tolaunchthis stack, it is necessary to firstly delete the stack, just as it already does in the cases of statesCREATE_FAILEDandROLLBACK_COMPLETE.PR Checklist
[Resolve #issue-number].poetry run tox) are passing.poetry run pre-commit run --all-files).and description in grammatically correct, complete sentences.
Approver/Reviewer Checklist
Other Information
Guide to writing a good commit