-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Resolve #359] Support use-previous-parameters #1476
[Resolve #359] Support use-previous-parameters #1476
Conversation
@RobReus Can you recall the extent to which you tested this feature yourself, besides the unit tests you have added? |
Some of this logic around validating the parameters would need to be moved to |
To avoid potential rework here, this PR would need to go in first. #1471 |
I have changed my mind about merging this considering that it adds some complexity in the code we have no known users who would benefit from the feature. |
I am adopting this stale PR by @RobReus
#914
Resolves #359
This new feature will make it possible to create and maintain stacks using Sceptre while also having the possibility to modify parameters outside of Sceptre, without Sceptre then overwriting/reverting these changes.
An example use-case: create and maintain your containerized environment using Sceptre, but after the initial deploy, maintain the Docker image tag using a CICD pipeline. When configuring the image tag parameter correctly, it will be given an initial value upon creation, but updates will not overwrite the value.
It is as simple as this:
It is fully backwards compatible and will not break existing functionality.
PR Checklist
[Resolve #issue-number]
.poetry run tox
) are passing.poetry run pre-commit run --all-files
).and description in grammatically correct, complete sentences.
Approver/Reviewer Checklist
Other Information
Guide to writing a good commit