[Resolve #1493] Complete DisableRollback implementation #1494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds missing code to complete the implementation of the DisableRollback feature. The implementation in 99c839a is clear that it was intended that this feature would cover both cases of creating and updating stacks, and this code and unit test was missed.
for more information, see https://pre-commit.ci
|
Integration test run https://github.com/Sceptre/sceptre/actions/runs/10226398355 |
zaro0508
requested changes
Aug 23, 2024
zaro0508
approved these changes
Aug 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds missing code to complete the implementation of the DisableRollback feature.
The implementation in 99c839a began this feature by adding disable rollback to the create and update CLI commands, but it was forgotten to update the stack actions.
This adds the missing code and another unit test.
PR Checklist
[Resolve #issue-number].poetry run tox) are passing.poetry run pre-commit run --all-files).and description in grammatically correct, complete sentences.
Approver/Reviewer Checklist
Other Information
Guide to writing a good commit