Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Resolve #1503] Dependency conflict with packaging #1504

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

alex-harvey-z3q
Copy link
Contributor

@alex-harvey-z3q alex-harvey-z3q commented Aug 27, 2024

This restores the flexible constraints on packaging, allowing >=16.8 for compatibility with many old tools in the Sceptre ecosystem.

For example:
https://github.com/Sceptre/sceptre-aws-stackoutput-resolver/blob/master/requirements.txt#L6

PR Checklist

  • Wrote a good commit message & description [see guide below].
  • Commit message starts with [Resolve #issue-number].
  • Added/Updated unit tests.
  • Added/Updated integration tests (if applicable).
  • All unit tests (poetry run tox) are passing.
  • Used the same coding conventions as the rest of the project.
  • The new code passes pre-commit validations (poetry run pre-commit run --all-files).
  • The PR relates to only one subject with a clear title.
    and description in grammatically correct, complete sentences.

Approver/Reviewer Checklist

  • Before merge squash related commits.

Other Information

Guide to writing a good commit

This restores the flexible constraints on packaging, allowing >=16.8 for
compatibility with many old tools in the Sceptre ecosystem.
@zaro0508
Copy link
Contributor

zaro0508 commented Aug 27, 2024

this reverts PR #1495 which was intended to address issue #1478. Even with this revert, what if an install of sceptre happens to install packaging version >16.8 ? wouldn't that still break downstream dependencies? I have a feeling that the right thing to do here is to move forward.

@alex-harvey-z3q
Copy link
Contributor Author

this reverts PR #1495 which was intended to address issue #1478.

It doesn't revert PR #1495, it restores the original version that I did of PR #1495. I believe the right thing to do here is merge this PR as soon as possible, otherwise latest Sceptre is broken for everyone in the world who tries to install any of our plugins along side of Sceptre. The other option would be to find and re-release every single plugin that has the 16.8 packaging dependency. That would take some time.

@alex-harvey-z3q alex-harvey-z3q merged commit 81a2ae1 into master Aug 28, 2024
12 checks passed
@alex-harvey-z3q alex-harvey-z3q deleted the ah/1503-packaging branch August 28, 2024 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants